Closes #490 fix_replace_symbol_in_expr: handle NAs and recursions#491
Closes #490 fix_replace_symbol_in_expr: handle NAs and recursions#491
Conversation
…_symbol_in_expr()
bms63
left a comment
There was a problem hiding this comment.
Could you help me understand what we mean by recursion in this context?
When I fixed the issue with the |
|
we can fix the links another time |
I don't think that any of the links are broken. I've have re-run it several times and the link where it fails differs. Either there was much traffic on github.com yesterday or our workflow sent request so quickly that the server could not handle them. Let's see if it happens again. |
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
mainbranch until you have checked off each task.styler::style_file()to style R and Rmd filesdevtools::document()so all.Rdfiles in themanfolder and theNAMESPACEfile in the project root are updated appropriatelyNEWS.mdunder the header# admiral (development version)if the changes pertain to a user-facing function (i.e. it has an@exporttag) or documentation aimed at users (rather than developers)pkgdown::build_site()and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()R CMD checklocally and address all errors and warnings -devtools::check()